Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always fail during tracking when authentication is required but invalid token is used #13675

Merged
merged 2 commits into from Nov 25, 2018
Merged

Always fail during tracking when authentication is required but invalid token is used #13675

merged 2 commits into from Nov 25, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 6, 2018 •
edited

fix #13471

Don't think a test is needed for the location ones.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 6, 2018
@tsteur tsteur added this to the 3.8.0 milestone Nov 6, 2018
sgiehl
sgiehl approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. rebased the branch to resolve the conflicts. Can be merged if tests passes

@sgiehl sgiehl merged commit 2862316 into 3.x-dev Nov 25, 2018
@sgiehl sgiehl deleted the 13471 branch November 25, 2018 13:33
@sgiehl sgiehl mentioned this pull request Nov 26, 2018
Merged
@tsteur tsteur mentioned this pull request Dec 13, 2018
Closed
tsteur added a commit to matomo-org/matomo-php-tracker that referenced this pull request Dec 13, 2018
@tsteur
Custom IP should be only sent when token is specified, otherwise the …
72069c0 
…request fails

The CIP parameter requires a token with at least write access. See matomo-org/matomo#13675

Didn't know the PHP tracker would set this parameter by default...
This was referenced Dec 13, 2018
Merged
Closed
diosmosis added a commit that referenced this pull request Dec 14, 2018
@diosmosis
Revert "Always fail during tracking when authentication is required b…
9366d84 
…ut invalid token is used (#13675)"

This reverts commit 2862316.
@diosmosis diosmosis mentioned this pull request Dec 14, 2018
Merged
diosmosis added a commit that referenced this pull request Dec 14, 2018
@diosmosis
Revert "Always fail during tracking when authentication is required b… (
67f4ec5 
#13858)

* Revert "Always fail during tracking when authentication is required but invalid token is used (#13675)"

This reverts commit 2862316.

* remove tests moved to integration test
sgiehl pushed a commit that referenced this pull request Apr 30, 2020
@tsteur @sgiehl
Always fail during tracking when authentication is required but inval…
6ce3f3f 
…id token is used (#13675)

* Always fail during tracking when authentication is required but invalid token used

* fix tests
sgiehl pushed a commit that referenced this pull request May 6, 2020
@tsteur @sgiehl
Always fail during tracking when authentication is required but inval…
faa338b 
…id token is used (#13675)

* Always fail during tracking when authentication is required but invalid token used

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.0
2 participants
@tsteur @sgiehl