Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML in report documentation is shown plain text #13668

Closed
sgiehl opened this issue Nov 5, 2018 · 1 comment
Closed

HTML in report documentation is shown plain text #13668

sgiehl opened this issue Nov 5, 2018 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.7.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Nov 5, 2018 •
edited

Some report documentation contains some HTML tags. Currently the filter rawSafeDecoded is used on that attribute, which causes all HTML-tags to be encoded.

Instead we might use the raw filter, but need to ensure that possible user input is encoded if there is any in some report documentation.

image

Note: This also regressed in the UI tests (https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/30903/UIIntegrationTest_actions_pages_tooltip_help.png)
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 5, 2018
@sgiehl sgiehl added this to the 3.7.0 milestone Nov 5, 2018
@tsteur
Copy link
Member

tsteur commented Nov 5, 2018

It would be good if the raw filter be only applied when a viewdatatable config option is enabled.

@diosmosis diosmosis mentioned this issue Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@tsteur @sgiehl