@diosmosis opened this Pull Request on November 2nd 2018 Member

Currently if a segment has a custom $sqlSegment that includes functions/operations (like UNIX_TIMESTAMP(log_visit.visit_first_action_time) - log_visit.days_since_first_visit * 86400), the joins for segment expressions won't be discovered. So if we try to use this segment w/ log_conversion, it will skip the log_visit join and fail.

This PR fixes that by parsing out table/column names from the segment expression.

Also includes a new public method to return the ArchiveWriter instance in ArchiveProcessor so it's easier to create new ArchiveProcessor instances from within Archivers.

@tsteur commented on November 4th 2018 Member

Can you add some tests for this @diosmosis ?

@diosmosis commented on November 4th 2018 Member

👍 will do

@diosmosis commented on November 5th 2018 Member

Added tests.

Powered by GitHub Issue Mirror