Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let plugins change content of JS Tracking Code Missing Email #13658

Merged
merged 1 commit into from Nov 2, 2018
Merged

Let plugins change content of JS Tracking Code Missing Email #13658

merged 1 commit into from Nov 2, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 31, 2018

Through DI...

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 31, 2018
@tsteur tsteur added this to the 3.7.0 milestone Oct 31, 2018
@tsteur tsteur requested a review from diosmosis October 31, 2018 19:42
@diosmosis
Copy link
Member

👍 makes sense. other option is to make Mail.send event pass $mail by reference.

@tsteur tsteur merged commit fcd604b into 3.x-dev Nov 2, 2018
@tsteur tsteur deleted the jstrackingcodemissingemail branch November 2, 2018 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis