Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to enumerate user #13654

Open
fadi-assaad opened this issue Oct 29, 2018 · 7 comments
Open

Possibility to enumerate user #13654

fadi-assaad opened this issue Oct 29, 2018 · 7 comments
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Comments

@fadi-assaad
Copy link

In Change your password page, user enumeration is happening and it must change.
Simply replace the message Error: Invalid username or e-mail address. Into something like an email has been sent to the address on record.

@Findus23 Findus23 added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Oct 29, 2018
@tsteur
Copy link
Member

tsteur commented Oct 30, 2018

I don't think we consider this a security issue. We even provide API methods for users with view access to check if a specific userLogin or userEmail exists.

@mattab
Copy link
Member

mattab commented Nov 5, 2018

users with view access have indeed the ability to check whether an account exists,

but wondering about anonymous user (thanks for reporting this issue @fadi-assaad), is it currently the only place where one can check whether a given username/email account exists?

@tsteur
Copy link
Member

tsteur commented Nov 5, 2018

I suppose there are couple more places... I wouldn't be surprised if UsersManager.getTokenAuth exposes it, and lots of other places.

@benji1000
Copy link

Hello, do you still consider user enumeration as a non-security issue? If yes, could you please take an official stance and close this issue? And if not, could you please fix it? Thank you for your answer.

FYI, OWASP seems to consider it as security issue.

@pesc
Copy link

pesc commented Mar 13, 2023

In my opinion, this is also a small security gap. A generic message is also displayed when logging in, and not whether the password or the email address is wrong: Wrong username and/or password.

The same behavior should happen with a password reset. A generic message like Password reset mail was sent if account exists, or something like that.

So what do you think @tsteur / @mattab about this approach?

@tsteur
Copy link
Member

tsteur commented Mar 14, 2023

We could change the error message for password reset and instead show a success message at all times and mention the email will be only received if entered correctly.

FYI quickly checking few providers and they are also showing an error message similar to us. Some other systems show the success message.

image

image

image

@davee-ndph
Copy link

This issue was picked up during a recent network penetration test, which included a public-facing server with Matomo 5.0.0 installed. After a bit of digging I found this 5-year-old issue :-)

The penetration tester noted:

  • Vulnerability "Password Reset Message User Enumeration" for the Change/Lost Password dialog
  • In common with other comments here, suggested: "the behaviour should be similar to the primary Sign In dialog which does not have this issue"
  • CVSSv3 score of 4.5 and severity MEDIUM; the real world applicability of that will depend on context, as always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

8 participants