Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Reporting API URL simpler when exporting custom report data #13645

Closed
mattab opened this issue Oct 25, 2018 · 2 comments
Closed

Keep Reporting API URL simpler when exporting custom report data #13645

mattab opened this issue Oct 25, 2018 · 2 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 25, 2018

When exporting custom report data, the URl looks like this:
untitled

The URL includes &reportUniqueId=CustomReports_getCustomReport_idCustomReport--2 but actually this URL parameter is not needed for the API.

So let's remove this parameter from Export API URLs.

@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Oct 25, 2018
@mattab mattab added this to the 3.8.0 milestone Oct 25, 2018
@sgiehl
Copy link
Member

sgiehl commented Oct 28, 2018

The export uses all parameters that are set as request parameters for the datatable. In that special case the custom report sets the uniqueReportId. We can't filter that list of parameters in core, as there is no way to identify if the parameter is required or not. We need to adjust that in the plugin.
ping @tsteur

@sgiehl sgiehl closed this as completed Oct 28, 2018
@sgiehl sgiehl added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Oct 28, 2018
@tsteur
Copy link
Member

tsteur commented Oct 28, 2018

The report unique ID is needed eg I think for the insights visualisation. It shouldn't be a problem to have this parameter in there?

@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants