update JShrink #13639
Closed
update JShrink #13639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be good to run the Jshrink tests with PHP 5.5 maybe. Looks like they run tests only for PHP 7+. Could obviously also easily regress later. Not sure if UI tests use the minified version or not (I think they do) |
|
BTW @Findus23 can you rebase/merge w/ 3.x-dev? I can't seem to get composer to create the composer.lock file correctly, it always includes two JSShrinks. |
|
See #14011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should hopefully make Matomo compatible with 7.3 and maybe even fix other issues without creating new ones.
see #13418