Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix switch continue in CreatePull #13635

Merged
merged 2 commits into from Nov 1, 2018
Merged

fix switch continue in CreatePull #13635

merged 2 commits into from Nov 1, 2018

Conversation

Findus23
Copy link
Member

Removes warning in PHP 7.3 (#13418)

@Findus23 Findus23 requested a review from sgiehl October 21, 2018 09:43
@Findus23 Findus23 added the Needs Review PRs that need a code review label Oct 21, 2018
@Findus23 Findus23 mentioned this pull request Oct 21, 2018
Closed
5 tasks
sgiehl
sgiehl approved these changes Oct 21, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have a 7.3 running, but changes look good

@sgiehl sgiehl merged commit 905d2ee into 3.x-dev Nov 1, 2018
@sgiehl sgiehl deleted the switch-continue branch November 1, 2018 12:52
@Findus23 Findus23 restored the switch-continue branch October 4, 2019 09:49
@sgiehl sgiehl deleted the switch-continue branch February 10, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Findus23 @sgiehl