Fix build and make join table sort stable by using DFS #13634
Conversation
|
Refs #13025 |
| // log_link_visit_action, log_action, log_visit, log_conversion, log_conversion_item | ||
| // which means if an array is supplied where log_visit comes before log_link_visitAction, it will | ||
| // be moved to after it. | ||
| static $implicitTableDependencies = [ |
There was a problem hiding this comment.
Not really, it's just a constant. I can remove the static modifier.
|
It's a complex PR/topic and don't understand all the code / hard to review so focused on looking at tests. Ran the system tests for most premium features and they seem to pass. Also checked custom reports generates similar queries that still work (some SQLs changed but are still valid). As nothing seems to break I reckon it's good to merge (in 3.8). |
|
I'll also go through the code and try to make it more expressive. |
diosmosis
force-pushed
the
fix-build2
branch
from
2e96078
to
8e56a88
Compare
|
Tried to make the code a bit clearer. |
core/Site.php
Outdated
|
|
||
| // for serialized format to be predictable across php/mysql/pdo/mysqli versions, make sure the int props stay ints | ||
| foreach ($this->site as $key => $value) { | ||
| if (is_numeric($value)) { |
There was a problem hiding this comment.
what about floats etc? It'd be actually better to really specify the properties that should be converted (like we do in other plugins) and not something generic
|
fyi we will need to test this with all premium features again, and especially custom reports to make sure the generated queries are still correct. |
|
ran the custom reports tests @diosmosis and looks all good 👍 |
Changes: