@diosmosis opened this Pull Request on October 21st 2018 Member

Changes:

  • Fix original format tests that fail on mysqli due to it returning ints by casting Site properties to int.
  • Make sure table sort in join tables is stable by using DFS instead of weighting tables. Join dependencies are parsed/assumed and dependent table/table-aliases get ordered first.
  • Couple other minor test fixes.
@diosmosis commented on October 21st 2018 Member

Refs #13025

@tsteur commented on November 12th 2018 Member

It's a complex PR/topic and don't understand all the code / hard to review so focused on looking at tests. Ran the system tests for most premium features and they seem to pass. Also checked custom reports generates similar queries that still work (some SQLs changed but are still valid). As nothing seems to break I reckon it's good to merge (in 3.8).

@diosmosis commented on November 12th 2018 Member

I'll also go through the code and try to make it more expressive.

@diosmosis commented on November 22nd 2018 Member

Tried to make the code a bit clearer.

@tsteur commented on November 25th 2018 Member

fyi we will need to test this with all premium features again, and especially custom reports to make sure the generated queries are still correct.

@tsteur commented on December 3rd 2018 Member

ran the custom reports tests @diosmosis and looks all good 👍

This Pull Request was closed on December 3rd 2018
Powered by GitHub Issue Mirror