Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme to reflect the new logo and brand color changes #13629

Merged
merged 8 commits into from Nov 13, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 18, 2018

We're going to update our logo, see https://matomo.org/blog/2018/10/matomo-logo-reveal/ and https://matomo.org/blog/2018/09/choose-your-favourite-logo/ . Thanks for voting and choosing our new logo!

As the logo contains some new brand colors we will reflect these changes in the Matomo app. Themes should be unaffected by this.

Matomo Mobile app is already updated in matomo-org/matomo-mobile-2@82dca1d but not yet released.

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 18, 2018
@tsteur tsteur added this to the 3.7.0 milestone Oct 18, 2018
@Findus23
Copy link
Member

I really like the new theme.

Really quick feedback:

And I think there are a few people who dislike bright colors, so maybe we should publish a really basic theme that sets theme-color-brand back to #37474f.

@tsteur
Copy link
Member Author

tsteur commented Oct 18, 2018

Cheers, fixing the theme color now.

Making the color contrast for warnings a wee bit better but even when choosing a #fff it won't be much better. Would need to change the background of the orange but AFAIK it's our brand orange...

Releasing a basic theme should be easily doable by just changing one or two color codes 👍 Could be like "Matomo 2018" or "Matomo colorless" :) For improved contrasts there could be maybe an extra theme as well if there is none already?

@@ -21,7 +21,7 @@

{% include "@CoreHome/_favicon.twig" %}
{% include "@CoreHome/_applePinnedTabIcon.twig" %}
<meta name="theme-color" content="#37474f">
<meta name="theme-color" content="#43a047">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure if we should use the green (#43a047) here. I think the theme-color should be the same color as the navbar (#3450A3).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik
grafik

I can't test in mobile chrome, but it seems there the color is also shown next to the navbar (#12491)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely should #3450A3 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@tsteur tsteur modified the milestones: 3.8.0, 3.7.0 Oct 31, 2018
@mattab mattab merged commit ac43235 into 3.x-dev Nov 13, 2018
@sgiehl sgiehl deleted the themeupdate branch November 13, 2018 20:46
@Findus23 Findus23 restored the themeupdate branch October 4, 2019 09:49
@sgiehl sgiehl deleted the themeupdate branch February 10, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants