Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PHP 5.x, Require PHP 7.2 #13611

Closed
Findus23 opened this issue Oct 15, 2018 · 12 comments
Closed

Drop support for PHP 5.x, Require PHP 7.2 #13611

Findus23 opened this issue Oct 15, 2018 · 12 comments
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
4.0.0

Comments

@Findus23
Copy link
Member

Findus23 commented Oct 15, 2018 •
edited

follow-up to #8156

Updated on 15.05.19 to latest news

I want to start this (probably controversial) discussion now, so when Matomo 4 will come out one day we will have found a consensus 🙂

PHP 5.6 (and also 7.0) went end of life and doesn't receive security updates anymore (even though it had the double security support duration than a normal PHP version)

Of course there will be Linux distributions that will continue to backport security fixes, most have moved on and only support PHP 7+.

  • Debian Stable comes with 7.3
    • previous Debian Stable (9) came with 7.0
  • Ubuntu LTS comes with 7.2, but in March 2020 the next LTS will come with 7.3
  • even RHEL 8 will come out soon and officially support PHP 7.2
  • [to be extended]

For comparison this are the requirements for other famous PHP applications:

  • TYPO3 9 LTS requires 7.2, 8 LTS requires 7.0
  • really popular CMS like joomla, wordpress, drupal, etc. support many 5.x versions as they can't raise the requirements without breaking many existing websites.
  • Moodle requires PHP 7.0
  • Mediawiki requires PHP 7.0
  • Prestashop requires PHP 5.4
  • Woocommerce requires PHP 5.6
  • Magento requires PHP 7.0.13
  • phpMyAdmin requires PHP 7.1
  • limesurvey requires PHP 5.5.9, but strongly recommends PHP 7.0+
  • Piwigo requires PHP 5.3 (recommended 7.0 or 7.1)
  • Nextcloud requires PHP 7.0
  • [to be extended]

Dropping support for 5.x will allow

  • all Matomo users to benefit from a significant performance boost
  • removing lots of old code in Matomo that is required to support older PHP versions
  • to lower the number of PHP versions that need to be tested at the same time and allow fokusing on providing full support for PHP 7.2 and all versions that will come in the next years until Matomo 5.
  • us to once and for all get rid of one of my most dreaded bugs that is responsible for the largest amount of support requests, many misunderstandings and lengthy explanations by me and the forum thread with by magnitudes highest number of views (42k) and is responsible for nearly 2% of the whole forum traffic: always_populate_raw_post_data=-1
  • updating dependencies of Matomo where newer versions depend on PHP 7 (e.g. Twig)
  • [to be extended]

Of course one can now check the PHP versions that are most used by Matomo users and see that PHP 5.6 shows up quite often there.
But I'd like to argue that this isn't showing the reality as :

  • The anonymous usage plugin hasn't been advertised for in a long time and hardly anyone is aware that it exists (the number of requests there dropped by more than 50% in 2018) and therefore only older Matomo instances will report data.
  • nearly all PHP 5.x users use the same version (the last one) while newer PHP versions are far more fragmented and therefore are not in the top list per version.
  • many people are using Matomo on shared hoster that provide more modern PHP versions, but are afraid of breaking customer websites and therefore keep all websites on the oldest supported version unless they manually change the PHP version (which few people who use shared hoster know about)

I'll continue to extend this post if I or someone else can think of more reasons to drop PHP 5.x in the next major Matomo release.

PS: I think if we decide so, this should be announced far before the upgrade and the last Matomo 3.x release should include a check that refuses to upgrade and shows an explaination on what to do to.
@Findus23 Findus23 added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Oct 15, 2018
@Findus23 Findus23 added this to the 4.0.0 milestone Oct 15, 2018
@sgiehl
Copy link
Member

sgiehl commented Oct 15, 2018

+1 for dropping 5.x support for Matomo 4

@fdellwing
Copy link
Contributor

+1 there are even PPAs for older Linux installs if needed.

@tsteur
Copy link
Member

tsteur commented Oct 15, 2018

Requiring PHP 7+ should be doable by the time we release Matomo 4. I'm sure we probably still have 20% PHP5.X usage but that should be fine. @mattab could give more accurate numbers.

@mattab
Copy link
Member

mattab commented Oct 24, 2018

Current stats of all Piwik/Matomo instances:

php         ratio    
5.6        30.81%    
7.0        23.42%    
7.1        12.04%    
5.5        10.55%    
7.2        10.09%    
5.3        6.68%    
5.4        5.03%    
5.2        1.33%    
7.3        0.06%

@mattab
Copy link
Member

mattab commented Oct 24, 2018

55% are still using PHP5

Should probably re-run the numbers and look at those who are using Matomo> 3.3.0 or so to restrict to users who keep Matomo somehow updated

@Findus23 Findus23 mentioned this issue Dec 4, 2018
Closed
@mattab mattab mentioned this issue Mar 11, 2019
Closed
@Findus23 Findus23 mentioned this issue Jul 9, 2019
Closed
@tsteur
Copy link
Member

tsteur commented Dec 16, 2019

I reckon we will want to directly only support PHP 7.2 or PHP 7.3?

Considering PHP7.2 will be end of life like half a year or so after Matomo 4 you wonder if we still want to support it? And anyone not being able to run PHP 7.2 would still be able to use Matomo 3.X which is supported for 1 year anyway.

The choice we make here also affects Matomo for WordPress of course and by the looks there we won't be able to send updates to users using an older version of PHP.

I reckon PHP 7.1 is not a question considering it is already EOL and we don't want to support an EOL version for the next 3 years or so.

Not sure what PHP versions are supported by different LTS linux distros. Looked here http://phpversions.info/operating-systems/ and some other sites but the information is outdated.

@mattab
Copy link
Member

mattab commented Dec 16, 2019

FYI current stats of all Piwik/Matomo instances:

php ratio
7.4 0.35%
7.3 15.52%
7.2 25.08%
7.1 12.55%
7 15.12%
5.6 19.02%
5.5 5.18%
5.4 2.85%
5.3 3.52%
5.2 0.78%
5.1 0.03%

and only for users on 3.11, 3.12 or 3.13 (installed/updated within the last 6 months)

php ratio
7.4 0.72%
7.3 27.94%
7.2 33.88%
7.1 13.21%
7 12.92%
5.6 9.17%
5.5 2.16%

Tricky to decide the minimum version to set...

@mattab
Copy link
Member

mattab commented Dec 16, 2019

are there already maybe strong reasons to drop 7.2 support (it is still security-supported by PHP team for almost another year), or could we still support PHP 7.2 for a while (maybe until PHP team itself supports it) and during the Matomo 4.x cycle, then when we need to require PHP 7.3 or even 7.4 or later, we could release a Matomo 5.0 (without many other changes) then?

@tsteur
Copy link
Member

tsteur commented Dec 16, 2019

It be more of a question whether there is a somewhat big distribution with an LTS version where users won’t be able to get PHP 7.3 by say May 2021… (when Matomo 3.x maybe retires... in worst case we could decide to support Matomo 3.x longer though).

Dropping support for PHP 7.2 be definitely good if any possible... It affects which features we can use, which libraries we can use, etc. Realistically, we will be likely working with Matomo 4 for 3 years or so... so we don't want to get any problems there.

Releasing a next major version of Matomo earlier we said few times before but I reckon realistically it wont really happen in the end.

We can see closer to the release also.

@sgiehl
Copy link
Member

sgiehl commented Feb 12, 2020

We already set minimum requirement to PHP 7.2 for Matomo 4. Guess we can close this issue and maybe create a new one to drop PHP 7.2 support somewhen? 🤔

@tsteur
Copy link
Member

tsteur commented Feb 12, 2020

I reckon be good to keep it open until closer to the release. We might go with PHP 7.3 at the end and would change things at some point. It be just good to keep it open as a reminder to evaluate the situation as we don't know yet when Matomo 4 will be ready etc. In theory, PHP 7.3 doesn't have much to offer, but there might be other reasons to directly go with PHP 7.3 such as other libs, hiring, getting more contributors etc which can be easier and more motivating when not an outdated PHP version needs to be supported etc.

@tsteur
Copy link
Member

tsteur commented Mar 20, 2020

Closing it for now and we can reopen if needed.

@tsteur tsteur closed this as completed Mar 20, 2020
@tsteur tsteur mentioned this issue Sep 18, 2020
Closed
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Sep 28, 2020
@mattab mattab changed the title Drop support for PHP 5.x Drop support for PHP 5.x, Require PHP 7.2 Sep 28, 2020
@mattab mattab removed the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
5 participants
@tsteur @mattab @sgiehl @Findus23 @fdellwing