@tsteur opened this Pull Request on October 15th 2018 Member
@diosmosis commented on October 15th 2018 Member

Tested on windows and it looks like it solves the problem in some cases but not all. Here's an example of it not working:

https://ufile.io/ores8

Didn't look into why exactly. Can probably merged though since it's not that big a bug.

@tsteur commented on October 15th 2018 Member

might just need a hire timeout maybe?

@diosmosis commented on October 15th 2018 Member

Maybe we could keep the scroll timeout going if the mouse is still pressed?

@tsteur commented on October 15th 2018 Member

@diosmosis I watched the video but not sure what happened in this case? Does it sometimes work in that browser and sometimes not?

The problem is that we can't really detect whether user is scrolling with touchpad or mousewheel or by using mouse click with scrollbar. Unless we maybe check if the position of the mouse is currently pretty much on the very right but making this all work can be tricky I reckon. Eg the mouse might be also moved while using the touchpad. So we would need to check if maybe mouseDown occurred, then scroll event => disable closing feature, meanwhile no mouseUp, on mouse up we enable closing feature again after short timeout or so. Not sure if it's worth it when it works in most cases. To be seen how it can be reproduced.

@diosmosis commented on October 15th 2018 Member

Think you detect if mouse is down, then in the timeout if it's down, schedule another 500ms timeout. When the mouse goes back up, the timeout gets cleared so even if the user pauses for a while while scrolling, it won't close the dropdown.

@tsteur commented on October 15th 2018 Member

done

@diosmosis commented on October 15th 2018 Member

Thanks, I realize it's probably not that important, but figured it was a simple change to apply.

This Pull Request was closed on November 24th 2018
Powered by GitHub Issue Mirror