New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When creating HTML reports in tmp/assets/ include a random string in the filename #13607
Conversation
Should this also remove the suffix from the filename? Could be possible w/ a |
Not sure what you mean? |
The issues says "which would be removed when the file is being downloaded via the API". I assumed that there needed to be some code to remove the extra string, maybe that's not needed? I haven't tested locally, will do that. |
Not sure what you mean. The file wouldn't be downloaded, it would be persisted on the file system and a user can access the report through the returned output path at any time... We may remove the option to save to disk from the API maybe? @mattab ... this option would be only needed for |
I can't remember why we need to store reports on disk? but if we can get rid of that, it would be best 👍 |
I see so there's no API method like |
Done.
Nope there isn't, there is only a direct download option for which the option "save on disk" is not needed. |
Looks like the MobileMessagingTest needs an update, otherwise good to merge |
Fixed the test 👍 |
fix #13586