Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating HTML reports in tmp/assets/ include a random string in the filename #13607

Merged
merged 3 commits into from Nov 29, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 14, 2018

fix #13586

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 14, 2018
@tsteur tsteur added this to the 3.7.0 milestone Oct 14, 2018
@diosmosis
Copy link
Member

Should this also remove the suffix from the filename? Could be possible w/ a Content-Disposition header I think.

@tsteur
Copy link
Member Author

tsteur commented Oct 15, 2018

Not sure what you mean?

@diosmosis
Copy link
Member

The issues says "which would be removed when the file is being downloaded via the API". I assumed that there needed to be some code to remove the extra string, maybe that's not needed? I haven't tested locally, will do that.

@tsteur
Copy link
Member Author

tsteur commented Oct 15, 2018

Not sure what you mean. The file wouldn't be downloaded, it would be persisted on the file system and a user can access the report through the returned output path at any time...

We may remove the option to save to disk from the API maybe? @mattab ... this option would be only needed for sendReport()

@mattab
Copy link
Member

mattab commented Oct 15, 2018

I can't remember why we need to store reports on disk? but if we can get rid of that, it would be best 👍

@diosmosis
Copy link
Member

The file wouldn't be downloaded, it would be persisted on the file system and a user can access the report through the returned output path at any time...

I see so there's no API method like downloadReport().

@tsteur
Copy link
Member Author

tsteur commented Oct 15, 2018

Done.

I see so there's no API method like downloadReport().

Nope there isn't, there is only a direct download option for which the option "save on disk" is not needed.

@diosmosis
Copy link
Member

Looks like the MobileMessagingTest needs an update, otherwise good to merge

@tsteur
Copy link
Member Author

tsteur commented Nov 29, 2018

Fixed the test 👍

@tsteur tsteur merged commit 1bea865 into 3.x-dev Nov 29, 2018
@tsteur tsteur deleted the 13586 branch November 29, 2018 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating HTML reports in tmp/assets/ include a random string in the filename
3 participants