@tsteur opened this Pull Request on October 11th 2018 Member

fix https://github.com/matomo-org/matomo/issues/12785

  • Only for new installations we use matomo.js|matomo.php through the API as default. For older installations we use piwik.js|piwik.php. This way we won't break anything when tracking code is embedded automatically (eg the case on 70k+ wordpress installations).
  • The tracking code generator and "site without data" screens show the matomo endpoint though.
  • Custom Piwik JS plugin has now an alias command ./console custom-matomo-js:update(won't update the plugin as it may break things, is complicated, etc. lets do this in Matomo 4.0 https://github.com/matomo-org/matomo/issues/13604)
  • The Custom JS plugin now updates /matomo.js and /piwik.js when generating the tracker file
  • The Custom JS plugin diagnostic check may check whether matomo.js and piwik.js is writable depending on when Matomo was installed
  • The Matomo endpoint can be enforced in the tracking API through a parameter (not really worth mentioning in the dev changelog as it is pretty much only for internal purposes).
  • Plugins that hook to Piwik.getJavascriptCode could now in theory rename the tracker endpoints matomo.js|php to anything else but the plugin would need to ensure those files exist etc.

We now also record the version number that was used to install Matomo so we can easier make changes in the future without breaking things for existing users.

@tsteur commented on October 14th 2018 Member
@diosmosis commented on November 29th 2018 Member

VisitorGenerator could probably use an update.

Otherwise looks good, conflicts need to be resolved though.

@tsteur commented on November 29th 2018 Member

VisitorGenerator could probably use an update.

@diosmosis you mean to send to matomo.php? I'll create an issue on the repository to do this at the latest for Matomo 4.0 This way we don't need to increase the required version for now etc. and ensures the plugin continues to work even if they block matomo.php .

@diosmosis can you maybe look into https://github.com/matomo-org/matomo-log-analytics/issues/224 ?

@diosmosis commented on November 29th 2018 Member

Looking now

@tsteur commented on November 29th 2018 Member

fyi created https://github.com/matomo-org/plugin-VisitorGenerator/issues/35 and will also prepare a PR for visitor generator shortly (renaming of the log files takes quite a while...)

@diosmosis commented on November 29th 2018 Member

@tsteur log importer PR: https://github.com/matomo-org/matomo-log-analytics/pull/235 and submodule update PR: https://github.com/matomo-org/matomo/pull/13776

The submodule update's tests won't pass until this PR is merged.

@tsteur commented on November 29th 2018 Member

UI tests should be fixed now. Merge conflicts resolved. Will probably merge soon if ok @diosmosis to avoid further conflicts

@diosmosis commented on November 29th 2018 Member

no issue for me if you merge

This Pull Request was closed on November 29th 2018
Powered by GitHub Issue Mirror