New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make matomo.js and matomo.php the default Tracking API endpoints used #13596
Conversation
fyi created matomo-org/matomo-log-analytics#224 |
CHANGELOG.md
Outdated
@@ -4,6 +4,11 @@ This is the Developer Changelog for Matomo platform developers. All changes in o | |||
|
|||
The Product Changelog at **[matomo.org/changelog](https://matomo.org/changelog)** lets you see more details about any Matomo release, such as the list of new guides and FAQs, security fixes, and links to all closed issues. | |||
|
|||
## Matomo 3.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated.
|
||
/** | ||
* Creates an entry in the User table for the "anonymous" user. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this & the above docblock needs to be changed or removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will update
VisitorGenerator could probably use an update. Otherwise looks good, conflicts need to be resolved though. |
@diosmosis you mean to send to @diosmosis can you maybe look into matomo-org/matomo-log-analytics#224 ? |
Looking now |
fyi created matomo-org/plugin-VisitorGenerator#35 and will also prepare a PR for visitor generator shortly (renaming of the log files takes quite a while...) |
@tsteur log importer PR: matomo-org/matomo-log-analytics#235 and submodule update PR: #13776 The submodule update's tests won't pass until this PR is merged. |
UI tests should be fixed now. Merge conflicts resolved. Will probably merge soon if ok @diosmosis to avoid further conflicts |
no issue for me if you merge |
fix #12785
piwik.js|piwik.php
. This way we won't break anything when tracking code is embedded automatically (eg the case on 70k+ wordpress installations)../console custom-matomo-js:update
(won't update the plugin as it may break things, is complicated, etc. lets do this in Matomo 4.0 Rename CustomPiwikJs plugin to CustomMatomoJs (or CustomTrackerJs) #13604)/matomo.js
and/piwik.js
when generating the tracker filematomo.js
andpiwik.js
is writable depending on when Matomo was installedPiwik.getJavascriptCode
could now in theory rename the tracker endpointsmatomo.js|php
to anything else but the plugin would need to ensure those files exist etc.We now also record the version number that was used to install Matomo so we can easier make changes in the future without breaking things for existing users.