Add more tests for format=original. #13584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Pull Request WIP
diosmosis
added
Needs Review
sgiehl
force-pushed
the
format-original-tests
branch
from
b98796b
to
cdb0faf
Compare
sgiehl
reviewed
Nov 4, 2018
There was a problem hiding this comment.
@diosmosis any reason for adding those tests? Imho it's very hard to validate if the content of each test file is correct. If it's only for proving the format original works, maybe there's a better way to check without comparing any file contents?
|
The original format is going to be used for another plugin that will unserialize after getting serialized data back over a network. Which means it can be easy to add new data to the result of an API method that cannot be unserialized. I suppose an alternative here is to just serialize & then unserialize it. Will look into that. |
diosmosis
force-pushed
the
format-original-tests
branch
from
22b665a
to
4761f45
Compare
|
Updated to just unserialize the response and check it unserialized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.