Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrer name should allow more than 70 characters (up to 255 characters) #13582

Closed
mattab opened this issue Oct 11, 2018 · 1 comment · Fixed by #15251
Closed

Referrer name should allow more than 70 characters (up to 255 characters) #13582

mattab opened this issue Oct 11, 2018 · 1 comment · Fixed by #15251
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 11, 2018

Currently, for some unknown reason (what was I thinking?!) the log_visit.referer_name and log_conversion.referer_name columns are limited to 70 characters. This can be very limiting because it is common for campaign names (for example) to exceed 70 characters.

I've just tested and it is not too slow, but it's definitely not fast to upgrade a column from VARCHAR 70 to VARCHAR 255. So we can't do it before Matomo 4.

  • it took 10 seconds to change the field on a log_conversion table with 200K rows
  • it took 680 seconds to change the field on log_visit with 5M rows

Related bug we recently discovered: #13573

Suggested steps

  • Change referer_name column to 255 length
  • Modify code to remove the 70 chars limit
  • add a test that referrer names with 250 characters are tracked, and retrieved correctly
  • Quickly check if some other columns have arbitrary varchar and should be increased as well?
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 11, 2018
@mattab mattab added this to the 4.0.0 milestone Oct 11, 2018
@sgiehl sgiehl self-assigned this Dec 9, 2019
@sgiehl
Copy link
Member

sgiehl commented Jan 25, 2020

fixed with #15251

@sgiehl sgiehl closed this as completed Jan 25, 2020
@mattab mattab changed the title Refererer name should allow more than 70 characters Referrer name should allow more than 70 characters Sep 28, 2020
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Sep 29, 2020
@mattab mattab changed the title Referrer name should allow more than 70 characters Referrer name should allow more than 70 characters (up to 255 characters) Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants