@diosmosis opened this Pull Request on October 10th 2018 Member

& make sure session is destroyed after a day if remember me is not used.

@tsteur commented on October 10th 2018 Member

Lets move this maybe into 3.7.0?

@diosmosis commented on October 10th 2018 Member

@tsteur moved

@diosmosis commented on October 11th 2018 Member

Verified it works.

Note: in order to test the session.gc_maxlifetime change, you'll have to add <a class='mention' href='https://github.com/ini_set'>@ini_set</a>('session.gc_divisor', 1); to make sure session GC is triggered. (I also set the lifetime to 60 so I wouldn't have to wait a day.)

@tsteur commented on December 6th 2018 Member

Added a comment as I'm not quite sure how gc_maxlifetime behaves. Otherwise looks good.

@diosmosis commented on December 8th 2018 Member

Actually this PR doesn't even work... not sure why I thought it did. Closing.

This Pull Request was closed on December 8th 2018
Powered by GitHub Issue Mirror