@Findus23 opened this Pull Request on October 10th 2018 Member

https://wayback.archive.org doesn't seem to exist anymore and the new website loads the content dynamically via react. But there is no need to parse the archive.org website, because they provide an API, that's perfect for this use case as it returns the closest match to a timestamp.

https://archive.org/help/wayback_api.php

@tsteur commented on October 10th 2018 Member

Do you know if there is a test for this feature? For some reason I'm not seeing an expected system test file for SEO.getRank or any other test.

@Findus23 commented on October 10th 2018 Member

@tsteur This is the only test of the SEO plugin:
https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/SEO/tests/Integration/SEOTest.php#L47

And only tests the rank and therefore couldn't detect this bug.

@tsteur commented on October 10th 2018 Member

Be good to add a test 👍

@Findus23 commented on October 11th 2018 Member

@tsteur Seems like I was wrong and the test tests all four values (as they are all called rank)
But because of 0e727311408cef75c7ba7bcb11b4fd989d8227e3 it skipped when one of them fails and as the alexa rank always fails (https://github.com/matomo-org/matomo/issues/13427), it didn't actually test anything.

This Pull Request was closed on November 4th 2018
Powered by GitHub Issue Mirror