Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible error in visitor profile when no visit found #13549

Merged
merged 1 commit into from Oct 30, 2018
Merged

Fix possible error in visitor profile when no visit found #13549

merged 1 commit into from Oct 30, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 5, 2018

Not tested but fix this fatal error

Error: {"message":"Call to a member function getColumn() on boolean","file":"plugins/Live/VisitorProfile.php","line":86}

Happened eg on

module=API&method=Live.getVisitorProfile&idSite=1&format=JSON&token_auth=XYZANONYMIZED&visitorId=b06bc6d6274c1244&limitVisits=-1

@tsteur
Fix possible error in visitor profile when no visit found
6769042 
Not tested but fix this fatal error
> Error: {"message":"Call to a member function getColumn() on boolean","file":"plugins\/Live\/VisitorProfile.php","line":86}

Happened eg on 
> module=API&method=Live.getVisitorProfile&idSite=1&format=JSON&token_auth=XYZANONYMIZED&visitorId=b06bc6d6274c1244&limitVisits=-1
@tsteur tsteur added the Needs Review PRs that need a code review label Oct 5, 2018
@tsteur tsteur added this to the 3.7.0 milestone Oct 5, 2018
sgiehl
sgiehl approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't able to reproduce the error locally. But code looks good 👍

@sgiehl sgiehl merged commit 06bf824 into 3.x-dev Oct 30, 2018
@sgiehl sgiehl deleted the visitprofilefatalrows branch October 30, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl