Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add campaign url builder widget #13546

Merged
merged 5 commits into from Nov 26, 2018
Merged

Add campaign url builder widget #13546

merged 5 commits into from Nov 26, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 5, 2018

fix #12795

image

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 5, 2018
@tsteur tsteur added this to the 3.7.0 milestone Oct 5, 2018
sgiehl
sgiehl requested changes Nov 26, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Left some minor comments.
Btw. wouldn't that widget be a good place to suggest to install the MarketingCampaignsReporting plugin, if it's not already installed? Guess we already do the same below the campaigns report?

plugins/Referrers/Widgets/GetCampaignUrlBuilder.php Outdated
$config->setCategoryId('Referrers_Referrers');
$config->setSubcategoryId('Referrers_URLCampaignBuilder');
$config->setName('Referrers_URLCampaignBuilder');
$config->setIsEnabled(SettingsPiwik::isSegmentationEnabled());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for hiding the widget if segmentation is disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I'll update it.

plugins/Referrers/angularjs/campaign-builder/campaign-builder.controller.js Outdated
@@ -0,0 +1,76 @@
/*!
* Piwik - free/libre analytics platform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated header. but guess we may need to update all files at once one day...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah at some point we need to update them all... will update it here anyway 👍

@tsteur
Copy link
Member Author

tsteur commented Nov 26, 2018

Pushed the update. We chose to not advertise the plugin there as we don't have installed on all of the accounts on the plugin for now and to keep things simple as we wouldn't want to show such a notice there etc.

@tsteur tsteur merged commit d3b46b1 into 3.x-dev Nov 26, 2018
@tsteur tsteur deleted the 12795 branch November 26, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Integrate the URL Builder directly into the app
2 participants
@tsteur @sgiehl