Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different icon for segmented visitor log #13544

Merged
merged 5 commits into from Nov 25, 2018
Merged

Use different icon for segmented visitor log #13544

merged 5 commits into from Nov 25, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 5, 2018

fixes #13419

as discussed using this icon
image

image

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 5, 2018
@tsteur tsteur added this to the 3.7.0 milestone Oct 5, 2018
sgiehl
sgiehl approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. UI Tests will need to be updated before merge.

@sgiehl sgiehl merged commit 762b6fa into 3.x-dev Nov 25, 2018
@sgiehl sgiehl deleted the 13419 branch November 25, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Same icon is used for "segmented visitor log" and "show visitor profile"
2 participants
@tsteur @sgiehl