Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alias from user settings. #13543

Merged
merged 2 commits into from Oct 5, 2018
Merged

Remove alias from user settings. #13543

merged 2 commits into from Oct 5, 2018

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Oct 4, 2018 •
edited

  • create issue to remove alias from DB in Matomo 4.0

Fixes #10165

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 4, 2018
@diosmosis diosmosis added this to the 3.6.1 milestone Oct 4, 2018
@tsteur
Copy link
Member

tsteur commented Oct 5, 2018

Haven't tested it but looks straight forward 👍

FYI: You could also already create a PR for Matomo 4 instead of creating an issue if it's easy to do.

@diosmosis
Copy link
Member Author

Created issue: #13547

@diosmosis diosmosis merged commit 8977a92 into 3.x-dev Oct 5, 2018
@diosmosis diosmosis deleted the user-alias branch October 5, 2018 03:25
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Remove alias from user settings. (matomo-org#13543)
82dde8f 
* Remove alias from user settings.

* Update UI test screenshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur