Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix unreproducible cloud error. #13542

Closed
wants to merge 1 commit into from
Closed

Try to fix unreproducible cloud error. #13542

wants to merge 1 commit into from

Conversation

diosmosis
Copy link
Member

Still can't reproduce locally, but this might get rid of the fatal error at least.

Fixes #13466

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 4, 2018
@diosmosis diosmosis added this to the 3.6.1 milestone Oct 4, 2018
@mattab
Copy link
Member

mattab commented Oct 4, 2018

To fix the problem could we instead just throw an exception if the data is not set correctly?

@diosmosis
Copy link
Member Author

I don't understand, you mean if $segment isn't Segment in the UnprocessedSegmentException throw?

@diosmosis
Copy link
Member Author

Moved out of milestone so closing.

@diosmosis diosmosis closed this Oct 7, 2018
@diosmosis diosmosis deleted the cloud-segment-fix branch October 7, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab