Only show default number of rows for device type report #13541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #12266 fyi @mattab couldn't make it work to show `0` instead of `-`. Now all the reports have the same length by default on the devices page. If someone wants to see more, they can increase the limit. Or if many are `-` then they can choose only `5` in the limit selection and it will apply this setting next time.
tsteur
added
not-in-changelog
|
@tsteur the |
|
Yeah I don't think we want to change it globally. I reckon it might be fine to keep the dash here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12266
fyi @mattab couldn't make it work to show
0instead of-.Now all the reports have the same length by default on the devices page. If someone wants to see more, they can increase the limit. Or if many are
-then they can choose only5in the limit selection and it will apply this setting next time.I reckon this is a good compromise. It lets users also still perform row evolution plus discover all the things/devices we can detect.