Cache cacheBuster generation when rendering a view #13536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Performance
|
User confirms this fixes #13329 |
refs #13329 Might not fix #13329 but should improve performance when rendering multiple views per pageload. It can be eg many when viewing visitor log etc. As the issue is referring to the "Segmented Visitor Log", it could actually fix that issue. Maybe for some reason the file cannot be written and it always re-generates it. `piwikVersionBasedCacheBuster ` is already cached in the method itself.
sgiehl
approved these changes
Nov 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #13329
Might not fix the issue #13329 but should improve performance when rendering multiple views per pageload. It can be eg many when viewing visitor log etc.
As the issue is referring to the "Segmented Visitor Log", it could actually fix that issue. Maybe for some reason the file cannot be written and it always re-generates it.
piwikVersionBasedCacheBusteris already cached in the method itself.