Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote db name in certain queries. #13529

Merged
merged 1 commit into from Oct 7, 2018
Merged

Quote db name in certain queries. #13529

merged 1 commit into from Oct 7, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 4, 2018
@diosmosis diosmosis added this to the 3.6.1 milestone Oct 4, 2018
sgiehl
sgiehl approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Guess the failing tests are unrelated?

@diosmosis
Copy link
Member Author

I think those were failing on 3.x-dev a while ago, fixed them but I probably didn't merge the fixes here. Will watch the 3.x-dev build.

@diosmosis diosmosis merged commit 5470c4f into 3.x-dev Oct 7, 2018
@diosmosis diosmosis deleted the dbname-escape branch October 7, 2018 19:46
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Quote db name in certain queries. (matomo-org#13529)
226cd13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl