Improve usage of requested site in plugin Controllers #13526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
diosmosis
reviewed
Oct 3, 2018
| $creationDateLocalTimezone = Date::factory($datetimeCreationDate, $website->getTimezone())->toString('Y-m-d'); | ||
| $todayLocalTimezone = Date::factory('now', $website->getTimezone())->toString('Y-m-d'); | ||
| if ($this->idSite) { | ||
| $datetimeCreationDate = $this->site->getCreationDate()->getDatetime(); |
There was a problem hiding this comment.
I notice in Plugin/Controller $this->site is set to new Site(), which can throw if the site doesn't exist. So it might be possible for the site to be null while $this->idSite is set. I think we should check for $this->site in the if statement to avoid that.
sgiehl
force-pushed
the
codeimprovements
branch
from
371c5a7
to
b92d83b
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.