Add tests for password resetter and tweak process a bit. #13523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will your changes also fix #13519? |
|
@sgiehl I haven't tested, but I believe so, will add to description. |
tsteur
reviewed
Oct 3, 2018
plugins/Login/PasswordResetter.php
Outdated
| @@ -274,7 +280,7 @@ public function generatePasswordResetToken($user, $expiryTimestamp = null) | |||
|
|
|||
| $expiry = strftime('%Y%m%d%H', $expiryTimestamp); | |||
| $token = $this->generateSecureHash( | |||
| $expiry . $user['login'] . $user['email'], | |||
| $expiry . $user['login'] . $user['email'] . $user['ts_password_modified'] . $resetTime, | |||
There was a problem hiding this comment.
Is it possible to include something random here? like Common::getRandomString()?
There was a problem hiding this comment.
👍 I can use a random string instead of the reset time.
|
Verified will fix #13519 |
diosmosis
force-pushed
the
reset-password-changes
branch
from
7fb6380
to
d65159d
Compare
sgiehl
reviewed
Oct 9, 2018
| use Piwik\AuthResult; | ||
| use Piwik\Container\StaticContainer; | ||
| use Piwik\Mail; | ||
| use Piwik\Plugins\Cloud\tests\Framework\TestCase\IntegrationTestCase; |
diosmosis
force-pushed
the
reset-password-changes
branch
from
d65159d
to
f9636cd
Compare
|
Updated. |
|
Tests are still failing on travis |
…t variables during tests).
tsteur
reviewed
Oct 12, 2018
plugins/Login/PasswordResetter.php
Outdated
| @@ -175,11 +176,12 @@ public function initiatePasswordResetProcess($loginOrEmail, $newPassword) | |||
|
|
|||
| $login = $user['login']; | |||
|
|
|||
| $this->savePasswordResetInfo($login, $newPassword); | |||
| $keySuffix = time() . Common::getRandomString(); | |||
There was a problem hiding this comment.
@diosmosis I reckon the only thing I'd change is to use Common::getRandomString($len = 32) just to have even more randomness. Otherwise looks good to me and it worked 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #13519
Fixes #13520