Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated menu structure and naming fixes #13518

Merged
merged 17 commits into from Dec 1, 2018
Merged

Updated menu structure and naming fixes #13518

merged 17 commits into from Dec 1, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 1, 2018

Naming fixes:

  • Visitors in Real Time => Visits in real time
  • Visitor Log => Visits log

Menu additions:

  • visits in Real time is now in the visitors menu

Menu changes:

  • Engagement => moved from visitors to behaviour
  • Slightly reordered reports within Visitors to list "Overview, Visits Log, Real time reports, Location, ... User ID, Custom Variables, Custom Dimensions".

Replaces #13414 which we keep open for now as it contains the "Visitors" report which we won't add for now due to performance reasons.

@tsteur tsteur mentioned this pull request Oct 1, 2018
Closed
@tsteur tsteur added this to the 3.7.0 milestone Oct 1, 2018
@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Needs Review PRs that need a code review labels Oct 1, 2018
@tsteur
Copy link
Member Author

tsteur commented Oct 2, 2018

There are a few more tests to fix but I reckon it is best to fix them after review and closer to the merge re conflicts.

@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Oct 2, 2018
@diosmosis diosmosis merged commit a61b7f3 into 3.x-dev Dec 1, 2018
@diosmosis diosmosis deleted the profiles_2 branch December 1, 2018 23:53
@sgiehl sgiehl mentioned this pull request May 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @diosmosis @sgiehl