Show unique visitors on visitor map as default if available #13517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
diosmosis
reviewed
Nov 30, 2018
| data[metric] = totalMetricValue; | ||
| $('.map-stats').html( | ||
| '<strong>' + formatValueForTooltips(data, metric, false) + '</strong>' + | ||
| (id != 'world' ? (' (' + formatPercentage(totalMetricValue / self.config.visitsSummary[metric]) + ')') : '') |
There was a problem hiding this comment.
should the percentage calculation be the other way around? ie, self.config.visitsSummary[metric] / totalMetricValue? And it's expected that for the first and last case in the if statement (id.length == 3 and else), that it will just be 100%, right?
There was a problem hiding this comment.
No. Should be correct that way. Maybe the names of the variables are a bit misleading. totalMetricValue holds the metric value for the selected/shown region (e.g. world,continent,country), and that is compared to the overall total. So self.config.visitsSummary[metric] is 100%. For the worldmap that would be always 100%, so it's now shown at all...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13456