Improve parameter handling in UsersManager.getUsers #13515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
|
Can a test be added to UsersManager/tests/Integration/APITest.php? |
tsteur
reviewed
Oct 1, 2018
plugins/UsersManager/API.php
Outdated
| * @return array the list of all the users | ||
| */ | ||
| public function getUsers($userLogins = '') | ||
| { | ||
| Piwik::checkUserHasSomeAdminAccess(); | ||
|
|
||
| $logins = array(); | ||
| if (!empty($userLogins)) { | ||
|
|
||
| if (is_array($userLogins)) { |
There was a problem hiding this comment.
or should we just fail if userLogins is not a string? In theory you may be able to send now some weird array structures to maybe cause an error? (haven't tested, just a thought)
There was a problem hiding this comment.
don't have a strong opinion on that. failing if no string is given works as well for sure
There was a problem hiding this comment.
lets do this to keep things simple 👍
tsteur
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aims to fix #13507 (comment)