Ensure segment param is used from url if no hash available #13512
Conversation
sgiehl
added
not-in-changelog
| @@ -529,10 +529,16 @@ function ajaxHelper() { | |||
| */ | |||
| this._mixinDefaultGetParams = function (params) { | |||
|
|
|||
| if (window.location.hash) { | |||
There was a problem hiding this comment.
If the hash isn't a valid query string (or has no segment), should we default to the segment in the URL?
There was a problem hiding this comment.
thought about it. but wasn't sure about any side effects. e.g. opening the dashboard with having a segment in the query string and in the hash. If it would be removed from the hash it would still load the one in query string which might not be correct/wanted
There was a problem hiding this comment.
Hmm, not sure about that. Thought this was how it worked for other query params (like date/period), but maybe not... (or maybe it shouldn't) cc @mattab
There was a problem hiding this comment.
Don't think the segment of the query string should be used if the one from the hash gets removed (be choosing no segment in UI)
When viewing widgets in widgetize mode, all parameters are directly contained in the query string instead of the hash. When appending a segment to the query string it wasn't automatically added to ongoing ajax request.