Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure idSite is set correctly for custom variable management #13510

Merged
merged 1 commit into from Sep 30, 2018
Merged

Ensure idSite is set correctly for custom variable management #13510

merged 1 commit into from Sep 30, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 30, 2018

fixes #13506

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 30, 2018
@sgiehl sgiehl added this to the 3.6.1 milestone Sep 30, 2018
@diosmosis diosmosis merged commit 0e37021 into 3.x-dev Sep 30, 2018
@diosmosis diosmosis deleted the customvariablesidsitecheck branch September 30, 2018 20:20
tsteur
tsteur reviewed Oct 1, 2018
View reviewed changes
plugins/CustomVariables/Controller.php

class Controller extends \Piwik\Plugin\Controller
{
public function manage()
{
$idSite = Common::getRequestVar('idSite');
$idSite = Common::getRequestVar('idSite', null, 'int');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi in a controller you can call $this->checkSitePermission(); for this. and also use $this->idSite in general

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. right. will check and replace some of the occurrences tomorrow

InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Ensure idSite is set correctly for custom variable management (matomo…
2500046 
…-org#13510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Error message Variable "topMenu" does not exist
3 participants
@sgiehl @tsteur @diosmosis