Add max_allowed_packet diagnostic check #13497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
fdellwing
reviewed
Sep 28, 2018
| $status = DiagnosticResult::STATUS_WARNING; | ||
| $pretty = MetricsFormatter::getPrettySizeFromBytes($maxPacketBytes['Value'], 'M'); | ||
| $configured = str_replace(array(' M', ' M'), 'MB', $pretty); | ||
| $comment = Piwik::translate('Diagnostics_MysqlMaxPacketSizeWarning', array('32MB', $configured)); |
There was a problem hiding this comment.
This should not be hardcoded I think.
There was a problem hiding this comment.
The referenced issue suggest to set it to at least 64MB, but guess 32MB might be fine as well?
There was a problem hiding this comment.
I don't remember exactly but we talked about it in chat or so. Somewhere 32 was said. Can change it to 64.
sgiehl
approved these changes
Nov 26, 2018
| $status = DiagnosticResult::STATUS_WARNING; | ||
| $pretty = MetricsFormatter::getPrettySizeFromBytes($maxPacketBytes['Value'], 'M'); | ||
| $configured = str_replace(array(' M', ' M'), 'MB', $pretty); | ||
| $comment = Piwik::translate('Diagnostics_MysqlMaxPacketSizeWarning', array('32MB', $configured)); |
There was a problem hiding this comment.
The referenced issue suggest to set it to at least 64MB, but guess 32MB might be fine as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1781
thought about linking to https://matomo.org/faq/troubleshooting/faq_183/ but the FAQ is actually not very helpful.