Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattened "entry page" and "exit page" take a long time to be generated #13496

Merged
merged 1 commit into from Nov 20, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 28, 2018

fix #11645

Debugged this on demo.matomo.org....

Wasn't as guessed https://github.com/matomo-org/matomo/blame/3.5.1/plugins/Actions/DataTable/Filter/Actions.php#L65-L67 but the flat parameter. After applying it the performance improved from minutes to less than a second.

fix #11645

Debugged this on demo.matomo.org.... 

Wasn't as guessed https://github.com/matomo-org/matomo/blame/3.5.1/plugins/Actions/DataTable/Filter/Actions.php#L65-L67  but the flat parameter. After applying it the performance improved from minutes to less than a second.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 28, 2018
@tsteur tsteur added this to the 3.7.0 milestone Sep 28, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Didn't have a closer look with debugger, but seems to be logical, as that way the fattening is already handled by the archive creator already and not in the end by DataTablePostProcessor

@tsteur tsteur merged commit d8a4d6d into 3.x-dev Nov 20, 2018
@tsteur tsteur deleted the 11645 branch November 20, 2018 22:41
@tassoman
Copy link
Contributor

Thank you team! 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flattened "entry page" and "exit page" take a long time to be generated
3 participants