Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send referrer to plugin authors website #13479

Merged
merged 2 commits into from Sep 25, 2018
Merged

Conversation

Findus23
Copy link
Member

Followup to #12780 and related to #13204

I noticed seeing foreign Matomo domains in my reports which seems to be caused by this missing noreferrer.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@sgiehl sgiehl added this to the 3.6.1 milestone Sep 25, 2018
@tsteur
Copy link
Member

tsteur commented Sep 25, 2018

👍 good find :)

@Findus23
Copy link
Member Author

Guess we should add #13204 soon or even add a Referer-Policy header to make sure the Matomo URL stays anonymous.

@diosmosis diosmosis merged commit 30492f6 into 3.x-dev Sep 25, 2018
@diosmosis diosmosis deleted the noopener-plugin-author branch September 25, 2018 20:37
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* don't send referrer to plugin authors website

* also add noreferrer to flattr link
@Findus23 Findus23 restored the noopener-plugin-author branch October 4, 2019 09:49
@sgiehl sgiehl deleted the noopener-plugin-author branch February 10, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants