FYI: Currently no site values will be saved except for trust cookies... need to figure out a way to make this happen
This should be enabled on an intranet website for accurate unique visitor tracking. Most visitors viewing an intranet will all have the same IP address, and often the same browser and operating system, which can cause Matomo to under-report the number of visits and unique visitors (if this setting is disabled).
Much better could be to create a new "Intranet" website type in Core Matomo. For Intranet websites, we directly enable the trust_visitor_cookies setting. This setting becomes a "website setting" de-activable in the UI and visible only for intranet sites.
I'll remove the setting again. must have misunderstood this one.
Removed the setting again and all related tests. Makes it easier :)
Added tests for the tracking part, should work.
must have misunderstood this one.
Forgot to reread the description so had missed this. But better we take the simplest approach 👍
Made the changes, will likely need to fix the tests after this
Looks like there are some integration test failures. The JsProxyTest one passes for me locally...
I'll restart the cancelled PR builds
Locally the test works for me as well
Test is still failing on travis, locally works. not sure why.
@diosmosis @mattab @sgiehl do you know why this test would check for url
http://localhost//js/?idsite=1 when it says
testPiwikPhp in https://github.com/matomo-org/matomo/blob/3.x-dev/tests/PHPUnit/Integration/JsProxyTest.php#L56 ?
fails probably because of a missing htaccess or so? Not sure why it suddenly fails... maybe changing to
js/index.php be fine?
@tsteur did you find out what the whole error was (ie, why it was getting a 400)?
Nope not yet. I'll enable debugging and see what happens
@tsteur there are some QueuedTracking tests still failing, doesn't look expected. Maybe something breaks tracking for queued tracking?