Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user-agent checking code in SessionAuth. #13470

Merged
merged 3 commits into from Sep 23, 2018

Conversation

diosmosis
Copy link
Member

Given the user agent can change for normal use cases like switching from mobile => desktop view on a mobile device, seems more inconvenient to have it.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Sep 22, 2018
@diosmosis diosmosis added this to the 3.6.1 milestone Sep 22, 2018
@tsteur
Copy link
Member

tsteur commented Sep 22, 2018

Awesome 👍

@diosmosis
Copy link
Member Author

@tsteur does that mean this is good to merge?

@tsteur
Copy link
Member

tsteur commented Sep 22, 2018

Haven't tested it but LGTM 👍

@diosmosis diosmosis merged commit faca30f into 3.x-dev Sep 23, 2018
@diosmosis diosmosis deleted the remove-user-agent-check branch September 23, 2018 22:08
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Remove user-agent checking code in SessionAuth.

* Fixing test.

* Fixing couple more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants