New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set backtrace on error object and check Piwik_ShouldPrintBackTraceWithMessage() #13450
Conversation
…hMessage() in controller instead of FrontController in case plugins decide to create their own safemode.
@@ -316,7 +316,9 @@ public function safemode($lastError = array()) | |||
|
|||
$errorMessage = $lastError['message']; | |||
|
|||
if (!empty($lastError['backtrace'])) { | |||
if (!empty($lastError['backtrace']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diosmosis is it on purpose that this is only done when output format is not HTML? I wonder if it is supposed to be shown on the safemode page when backtrace with message is enabled? I think before it was the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there was no backtrace to display in the code before (but I never paid that much attention to the safemode html).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can display it in the View as well.
LGTM if tests pass |
…hMessage() (#13450) * Set backtrace on error object and check Piwik_ShouldPrintBackTraceWithMessage() in controller instead of FrontController in case plugins decide to create their own safemode. * Add backtrace to HTML safemode view too. * Fixing test.
…hMessage() (matomo-org#13450) * Set backtrace on error object and check Piwik_ShouldPrintBackTraceWithMessage() in controller instead of FrontController in case plugins decide to create their own safemode. * Add backtrace to HTML safemode view too. * Fixing test.
… in controller instead of FrontController in case plugins decide to create their own safemode.