Mention Piwik 2 is no longer supported (Piwik 2.18) #13448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Changed it to at least view access. Would in theory need to show super user email login names or their email so they can ask them to update. |
diosmosis
reviewed
Dec 5, 2018
| { | ||
| if (!Piwik::isUserHasSomeViewAccess()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Should this show for anonymous users?
There was a problem hiding this comment.
I would say so. I think we discussed it in the chat but not 100% sure. Maybe @mattab can confirm.
diosmosis
reviewed
Dec 5, 2018
| {% endif %} | ||
| </div> | ||
| </div> | ||
| {% endblock %} |
There was a problem hiding this comment.
I guess this shouldn't be translated?
There was a problem hiding this comment.
No translation needed. Discussed it in the chat a while ago. It wouldn't be translated in time likely anyway and it'll be the last update.
diosmosis
reviewed
Dec 5, 2018
| @@ -49,6 +49,13 @@ public function getDefaultAction() | |||
| return 'redirectToCoreHomeIndex'; | |||
| } | |||
|
|
|||
| public function piwikIsOutdated() | |||
| { | |||
| Piwik::checkUserHasSomeViewAccess(); | |||
There was a problem hiding this comment.
Should this be shown to anonymous viewers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to keep it simple... showing warning to all admins/super users in reporting/admin UI:
And simple page showing more info
didn't add any of the piwik is now matomo image etc as didn't want to put it under GPL and I would say it is better to keep it straight to the point.
refs #11810