Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Referrer Type to Channel Type #13447

Merged
merged 4 commits into from Nov 25, 2018
Merged

Rename Referrer Type to Channel Type #13447

merged 4 commits into from Nov 25, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 18, 2018

fixes #12969

I think it makes things slightly better but all good if we don't want to merge it. Uses more common (marketing) terms for it instead of the technical terms IMO.

Will update screenshots once confirmed we want this change.

fixes #12969 

I think it makes things slightly better but all good if we don't want to merge it. Uses more common (marketing) terms for it instead of the technical terms IMO.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 18, 2018
@tsteur tsteur added this to the 3.7.0 milestone Sep 18, 2018
@mattab
Copy link
Member

mattab commented Sep 18, 2018

I think this will work and bring more consistency.
it's definitely a good time to make wording changes, before we update user guides 👍

@tsteur tsteur merged commit ae0460f into 3.x-dev Nov 25, 2018
@tsteur tsteur deleted the 12969 branch November 25, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Referrer Type to Acquisitions Type (or Channel)
3 participants