Create periods with timezones in a couple places that are missing it. #13445
Conversation
diosmosis
added
Bug
|
@tsteur I'm wondering if my understanding of how matomo deals w/ timezones is correct. It's used sometimes when creating periods/dates, but not always. EDIT: dealt with. |
|
@diosmosis which issue fixes this here? |
|
|
||
| if (strpos($endDate, '-') === false) { |
There was a problem hiding this comment.
why do we need to apply the timezone in one case but not the other?
I would have actually expected we wouldn't need to apply a timezone here at all... especially since it doesn't seem to be used for real time / raw data. Or is it applied in case there is today/yesterday? Actually I think I just answered the question :) a comment be good that the timezone might be only needed for today/yesterday basically.
For some reason I would not have expected the timezone eg in $last30Relative = new Range($period, $lastN, $timezone); Might be a bug.
There was a problem hiding this comment.
lastN is based on today, so we'd need the timezone to figure out what 'today' is for the site?
There was a problem hiding this comment.
I see... it is used when last parameter is not set 👍
|
@tsteur fixes this issue: #13369 (comment) |
|
LGTM if tests pass |
|
thanks for adding the comment, 👍 |
…matomo-org#13445) * Create periods with timezones in a couple places that are missing it. * tweak * Apply timezone only if endDate is not a normal date. * add comment
No description provided.