Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips appear all over the place but shouldn't #13442

Merged
merged 2 commits into from Nov 21, 2018
Merged

Tooltips appear all over the place but shouldn't #13442

merged 2 commits into from Nov 21, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 18, 2018

fix #13305

Add a delay so tooltips don't appear immediately. Do not show any tooltip for any form field.

In visitor log the titles are still shown immediately but there it is wanted maybe?

I clicked through couple of pages and looked a bit in the code but it is hard to find all the places where a title attribute should be removed. Maybe we do this better over time.

fix #13305 

Add a delay so tooltips don't appear immediately. Do not show any tooltip for any form field.

In visitor log the titles are still shown immediately but there it is wanted maybe?

I clicked through couple of pages and looked a bit in the code but it is hard to find all the places where a title attribute should be removed. Maybe we do this better over time.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 18, 2018
@tsteur tsteur added this to the 3.7.0 milestone Sep 18, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and guess it makes sense to remove unwanted tooltips over time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips appear all over the place but shouldn't
2 participants