@tsteur opened this Pull Request on September 17th 2018 Member

fixes https://github.com/matomo-org/matomo/issues/13438

I know the check user has view access calls are not needed since they are checked in the archive classes that we call and it is safe. I got confused there though for a second and I think it is better to have them there in case things get refactored at some point and forgets to add such calls etc. Can remove them again if wanted.

@diosmosis commented on September 20th 2018 Member

Should we add the check view access function to all reporting API methods? Otherwise seems inconsistent, no?

@tsteur commented on September 20th 2018 Member

Could do... didn't check if it is missing in other APIs. I thought we always added it to all methods and was first time I see them not there.

@diosmosis commented on September 20th 2018 Member

I think most don't have them. Might be some work to add them to all methods.

@tsteur commented on September 21st 2018 Member

I'll go over some APIs now

@tsteur commented on September 21st 2018 Member

done

This Pull Request was closed on September 23rd 2018
Powered by GitHub Issue Mirror