Fix fatal when multiple sites are requested in referrers API report #13439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Should we add the check view access function to all reporting API methods? Otherwise seems inconsistent, no? |
|
Could do... didn't check if it is missing in other APIs. I thought we always added it to all methods and was first time I see them not there. |
|
I think most don't have them. Might be some work to add them to all methods. |
|
I'll go over some APIs now |
|
done |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…atomo-org#13439) * Fix fatal when multiple sites are requested in referrers API report * add more checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13438
I know the check user has view access calls are not needed since they are checked in the archive classes that we call and it is safe. I got confused there though for a second and I think it is better to have them there in case things get refactored at some point and forgets to add such calls etc. Can remove them again if wanted.