@sgiehl opened this Pull Request on September 17th 2018 Member

ping @mattab @tsteur

When tracking emojis in e.g. page titles, the page title currently will result in an empty value (or maybe an error, depending on mysql config)

Not sure why we currently replace those characters only for the url and not all params...

refs #8790

also kind of fixes #13148

@tsteur commented on September 17th 2018 Member

Not sure why it wasn't done on the whole URL but makes sense I suppose. Original issue was
https://github.com/matomo-org/matomo/issues/7766 and fixed in https://github.com/matomo-org/matomo/pull/8765 . Couldn't find any discussion around this. As it is done in the constructor before data is sanitized it should be fine I presume.

@diosmosis commented on September 20th 2018 Member

Should we add a test for this (ie, tracking data w/ emojis for example)?

@tsteur commented on September 25th 2018 Member

There are some failing tests. not sure if related to this PR? otherwise if they pass lgtm

@sgiehl commented on September 28th 2018 Member

@tsteur tests related to that PR should be fixed now

This Pull Request was closed on September 28th 2018
Powered by GitHub Issue Mirror