Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Movers And Shakers widget to default dashboard #13435

Closed
wants to merge 1 commit into from
Closed

Add Movers And Shakers widget to default dashboard #13435

wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 17, 2018

Could also move it to top left even before the "Visitors in real time widget"? @mattab any preference? As it may be quite useful to see it first, but not needed.

fixes #13153

@tsteur
Add Movers And Shakers widget to default dashboard
a529165 
Could also move it to top left even before the "Visitors in real time widget"? @mattab any preference? As it may be quite useful to see it first, but not needed.

fixes #13153
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 17, 2018
@tsteur tsteur added this to the 3.7.0 milestone Sep 17, 2018
@mattab
Copy link
Member

mattab commented Sep 24, 2018

it's a good idea but the problem is that Movers & Shakers does not yet work for custom date ranges. Most users will have a date range selected as their default period, and the widgets shows only a message It is not possible to generate insights for this date and period combination.

-> Would it be possible to add support for custom date range in Movers & Shakers first?

@tsteur
Copy link
Member Author

tsteur commented Sep 25, 2018

Probably not, lets move it out of the milestone then.
BTW: Most users will have today or yesterday as their default period quite likely ;) I doubt too many people even change it or know they can change it ;)

@diosmosis
Copy link
Member

Adding WIP tag since this can't be merged yet

@diosmosis diosmosis added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels Dec 5, 2018
@tsteur
Copy link
Member Author

tsteur commented Dec 6, 2018

I'll move it to 3.10 then. Although I highly doubt most users change their default date and even set it to a date range :)

@tsteur tsteur modified the milestones: 3.8.0, 3.10.0 Dec 6, 2018
@mattab mattab modified the milestones: 3.11.0, 3.10.0 Mar 20, 2019
@mattab mattab removed this from the 3.10.0 milestone May 28, 2019
@mattab
Copy link
Member

mattab commented Jun 27, 2019

how much work would it be to make movers & shakers work for custom date ranges? covered in #5815

Will close it for now but be great to merge this once #5815 is fixed

@mattab mattab closed this Jun 27, 2019
@mattab mattab mentioned this pull request Jun 27, 2019
Open
@tsteur tsteur deleted the 13153 branch December 16, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Movers and shakers" widget to the default dashboard
3 participants
@tsteur @mattab @diosmosis