Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return access entries only for sites that still exist #13433

Merged
merged 3 commits into from Sep 20, 2018
Merged

Return access entries only for sites that still exist #13433

merged 3 commits into from Sep 20, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 17, 2018

This should have been only an issue when a site was deleted manually by the looks.

fix #13423

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 17, 2018
@tsteur tsteur added this to the 3.6.1 milestone Sep 17, 2018
@diosmosis
Copy link
Member

diosmosis commented Sep 20, 2018 •
edited

Not sure why, but the UsersManagerTest is failing now

Otherwise code looks good

@diosmosis diosmosis merged commit a7f5d64 into 3.x-dev Sep 20, 2018
@diosmosis diosmosis deleted the 13423 branch September 20, 2018 21:26
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Return access entries only for sites that still exist (matomo-org#13433)
38d6184 
* Return access entries only for sites that still exist

* Fix UsersManager tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Anonymous user settings results in an error when site no longer exists
2 participants
@tsteur @diosmosis