Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow session to be writable in CLI mode so tests can write values. #13430

Merged
merged 1 commit into from Sep 14, 2018
Merged

Allow session to be writable in CLI mode so tests can write values. #13430

merged 1 commit into from Sep 14, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Sep 14, 2018
@diosmosis diosmosis added this to the 3.6.1 milestone Sep 14, 2018
@tsteur
Copy link
Member

tsteur commented Sep 14, 2018

Should be good to merge if tests pass 👍

@diosmosis diosmosis merged commit 608fd98 into 3.x-dev Sep 14, 2018
@diosmosis diosmosis deleted the session-write-for-test branch September 14, 2018 05:48
diosmosis added a commit that referenced this pull request Sep 20, 2018
@diosmosis
Allow session to be writable in CLI mode so tests can write values. (#…
4c2f03d 
…13430)
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Allow session to be writable in CLI mode so tests can write values. (m…
fcff765 
…atomo-org#13430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur