Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Request::processRequest() so API events are triggered. #13428

Merged
merged 2 commits into from Sep 16, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Sep 14, 2018
@diosmosis diosmosis added this to the 3.6.1 milestone Sep 14, 2018
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but looks good to merge.

@tsteur
Copy link
Member

tsteur commented Sep 16, 2018

Just noticing there were also custom dimension changes that should probably not be merged... can we exclude this in the PR?

@diosmosis
Copy link
Member Author

@tsteur removed submodule change, will merge now

@diosmosis diosmosis merged commit 0bbd21d into 3.x-dev Sep 16, 2018
@diosmosis diosmosis deleted the usersmanager-controller-api branch September 16, 2018 22:00
diosmosis added a commit that referenced this pull request Sep 20, 2018
* Use Request::processRequest() so API events are triggered.

* Undo CustomDimensions submodule.
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…g#13428)

* Use Request::processRequest() so API events are triggered.

* Undo CustomDimensions submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants