New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use placeholder for unsubscribe link and place it near the normal email footer content. #13421
Conversation
@diosmosis could you do a rebase? |
fea3f96
to
abc0fd0
Compare
@sgiehl Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the little comment, looks good and works (also with Whitelabel)
@@ -1,16 +1,26 @@ | |||
{% set fontStyle %}color:{{ themeStyles.colorText|e('html_attr') }};font-family:{{ themeStyles.fontFamilyBase|e('html_attr') }};{% endset %} | |||
c{% set styleParagraph = 'font-size:15px;line-height:24px;margin:0 0 16px;' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a c
in front of that line that should be removed again
…il footer content. (matomo-org#13421) * Use placeholder for unsubscribe link and place it near the normal email footer content. * padding tweak for whitelabel * fix unsubscribe link escaping replace issue * Move _htmlReportFooter contents to _htmlEmailFooter.twig. * Remove stray 'c'
Fixes #13330
@sgiehl can you review?
Here's what it looks like:
w/ WhiteLabel enabled: